Adding additional metrics to track #79
Open
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding multus/monitoring Signed-off-by: Joe Talerico aka rook <[email protected]>
|
Do we also want these on node-density or only care about them from cluster-density? |
afcollins
reviewed
Dec 17, 2024
| @@ -35,6 +35,28 @@ tests : | |||
| - "[Jira: kube-apiserver]" | |||
| direction: 1 | |||
|
|
|||
| - name: multusCPU | |||
There was a problem hiding this comment.
We should decide whether we want all metrics (including those not added here) to aggregate only the workload or also include the garbage collection metrics (lines 21-22 above).
afcollins
reviewed
Dec 17, 2024
| metric_of_interest: value | ||
| agg: | ||
| value: cpu | ||
| agg_type: avg |
There was a problem hiding this comment.
This averages all pods and containers in the namespace .. do we want to focus on a container specifically? I think kube-rbac-proxy would be weighing it down
afcollins
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adding multus/monitoring
Related Tickets & Documents
Checklist before requesting a review
Testing